Skip to content

Fix script-src directive in web analytics FAQ#32079

Open
brentonrace wants to merge 1 commit into
cloudflare:productionfrom
brentonrace:patch-1
Open

Fix script-src directive in web analytics FAQ#32079
brentonrace wants to merge 1 commit into
cloudflare:productionfrom
brentonrace:patch-1

Conversation

@brentonrace

Copy link
Copy Markdown

Summary

Corrected the script-src directive in web analytics FAQ to include a trailing slash to support versioned URLs like https://static.cloudflareinsights.com/beacon.min.js/v4513226cdae34746b4dedf0b4dfa099e1781791509496

Documentation checklist

Corrected the script-src directive to include a trailing slash to support versioned URLs like https://static.cloudflareinsights.com/beacon.min.js/v4513226cdae34746b4dedf0b4dfa099e1781791509496
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning found in commit 490160f.

Fix in your agent
Fix the following review findings in PR #32079 (https://github.com/cloudflare/cloudflare-docs/pull/32079).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.

---

## Code Review

### Warnings (1)

#### CR-d96b52ef2c70 · Incorrect CSP path example
- **File:** `src/content/docs/web-analytics/faq.mdx` line 117
- **Issue:** The `script-src` example uses `https://static.cloudflareinsights.com/beacon.min.js/`. CSP path matching treats this trailing slash as a directory prefix, so it matches `/beacon.min.js/*` but not `/beacon.min.js` itself—yet the actual beacon `<script src>` shown on this page loads `beacon.min.js` without a trailing slash.
- **Fix:** Remove the trailing slash: use `https://static.cloudflareinsights.com/beacon.min.js` so the directive matches the beacon script URL.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
web-analytics/faq.mdx line 117 Incorrect CSP path example — The script-src example uses https://static.cloudflareinsights.com/beacon.min.js/. CSP path matching treats this trailing slash as a directory prefix, so it matches /beacon.min.js/\* but not /beacon.min.js itself—yet the actual beacon <script src> shown on this page loads beacon.min.js without a trailing slash. Fix: Remove the trailing slash: use https://static.cloudflareinsights.com/beacon.min.js so the directive matches the beacon script URL.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants