[Cloudflare One] Update Keycloak SAML docs#32071
Open
kennyj42 wants to merge 1 commit into
Open
Conversation
Contributor
Review
Fix in your agentFix the following review findings in PR #32071 (https://github.com/cloudflare/cloudflare-docs/pull/32071).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Style Guide Review
### Warnings (1)
#### SG-690f10b9299b · Use turn on/turn off for toggles
- **File:** `src/content/docs/cloudflare-one/integrations/identity-providers/keycloak.mdx` line 51
- **Issue:** Added line reads `If you wish to enable client signatures, enable **Client Signature Required** and select **Save**.`
- **Fix:** Replace `enable` with `turn on` for the toggle: `If you want to turn on client signatures, turn on **Client Signature Required** and select **Save**.`
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewWarnings (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://jira.cfdata.org/browse/AUTH-8879
Summary
Validation