[Logs] Update Logpush dataset field definitions (2026-07-14)#32066
Conversation
|
/bonk please review this automated sync of Logpush dataset field definitions. Focus on the following:
|
Review✅ No issues found in commit Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Review of PR #320661. Changelog qualityNo changelog needed — correct call. 2. Field description qualityThe changes are accurate and consistent with existing conventions:
All descriptions use the same machine-generated template ( 3. Manual edits at risk of being overwrittenYes — both changed files contain manual editorial additions (internal links, cross-references, and contextual guidance) that will be lost on the next automated sync unless they are preserved in the internal source YAML. In
|
|
Preview URL: https://64e4d1db.preview.developers.cloudflare.com |
|
/bonk What you said is not correct, there are no changes on the listed fields: |
|
You are absolutely right. Looking at the actual diff in this PR, point #3 in the previous review is incorrect. This PR only appends new enum values to three fields:
None of the fields flagged in the previous review as containing manual editorial additions ( Corrected assessment: No manual edits are at risk of being overwritten by this automated sync. The changes are limited strictly to enum list expansions on machine-generated description lines. The rest of the review stands:
|
Summary
Automated sync of Logpush dataset field definitions from data/entities.
Files changed
src/content/docs/logs/logpush/logpush-job/datasets/account/— dataset pagessrc/content/docs/logs/logpush/logpush-job/datasets/zone/— dataset pagesDocumentation checklist