docs(log-explorer): document that MatchedRules is not populated by cache rules#32041
Open
zeinjaber wants to merge 1 commit into
Open
docs(log-explorer): document that MatchedRules is not populated by cache rules#32041zeinjaber wants to merge 1 commit into
zeinjaber wants to merge 1 commit into
Conversation
…che rules Closes DEE-3705
Contributor
Review
Fix in your agentFix the following review findings in PR #32041 (https://github.com/cloudflare/cloudflare-docs/pull/32041).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Style Guide Review
### Warnings (1)
#### SG-eaae7e15a872 · No trailing punctuation in headings
- **File:** `src/content/docs/log-explorer/faq.mdx` line 18
- **Issue:** Heading `## Why is the \`MatchedRules\` field empty for some requests?` ends with `?`
- **Fix:** Remove the `?` from the heading
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewWarnings (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://e5f59b2b.preview.developers.cloudflare.com Files with changes (up to 15)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a FAQ entry to the Log Explorer FAQ page explaining that
MatchedRulesis only populated by security and transformation rules, not cache rules.Why
Customers querying
MatchedRulesto investigate cache rule behavior get empty results with no explanation. The HTTP requests dataset field definition is auto-generated and cannot be edited directly, making the FAQ the appropriate location for this clarification.Files changed
src/content/docs/log-explorer/faq.mdx— new FAQ entry before the query timeout section (+4 lines)How to verify
Navigate to /log-explorer/faq/ and confirm the new entry appears near the top of the FAQ.
Closes DEE-3705