Skip to content

[Cloudflare One] Document local emergency disconnect#31120

Open
jiulingz wants to merge 1 commit into
cloudflare:productionfrom
jiulingz:jolin/local-emergency-disconnect
Open

[Cloudflare One] Document local emergency disconnect#31120
jiulingz wants to merge 1 commit into
cloudflare:productionfrom
jiulingz:jolin/local-emergency-disconnect

Conversation

@jiulingz
Copy link
Copy Markdown
Collaborator

Summary

Adds documentation for local emergency disconnect feature (RM-29186) landing in 2026.5.0. This feature allows organizations to trigger an emergency disconnect on the device itself, without network access.

Documentation checklist

@jiulingz
Copy link
Copy Markdown
Collaborator Author

/bonk review

1 similar comment
@csujedihy
Copy link
Copy Markdown
Collaborator

/bonk review

Comment thread public/__redirects Outdated
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing review submission.

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test line 50

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test line 280

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test line 370

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues need fixing before merge — one broken link (cannot inline-suggest because the line sits between diff hunks), one style guide violation, and one formatting fix.

CRITICAL

  • emergency-disconnect.mdx:~380 — Broken internal link anchor. The heading changed to ### Clear External Emergency Disconnect, so the link [turn off External Emergency Disconnect](#clear-external-emergency-disconnect-state) should point to #clear-external-emergency-disconnect.

MEDIUM

  • emergency-disconnect.mdx:370 — Use "turn off" instead of "disable" per style guide; also use imperative mood ("push" not "pushing").
  • emergency-disconnect.mdx:280 — Config key and boolean value need backticks per text formatting rules.

LOW

  • emergency-disconnect.mdx:3 — Description (38 chars) is below the 50-character minimum.

Note: The PR body leaves the changelog checkbox unchecked. For a new feature landing in 2026.5.0, consider adding a changelog entry so customers can discover it via RSS and Discord.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 29, 2026

Submitted the review on PR #31120. Here's what I found:

3 issues need fixing before merge:

  • CRITICAL — Broken internal link in emergency-disconnect.mdx (~line 380). The heading was renamed to ### Clear External Emergency Disconnect, but the link still points to the old anchor #clear-external-emergency-disconnect-state. It should be #clear-external-emergency-disconnect.
  • MEDIUM — Style guide violation in emergency-disconnect.mdx (line 370): "disable" should be "turn off", and "pushing" should be "push" (imperative mood).
  • MEDIUM — Missing backticks in emergency-disconnect.mdx (line 280): emergency_disconnect and false should both be wrapped in backticks.
  • LOW — Description frontmatter is only 38 characters (minimum is 50).

I posted inline suggestions for the 3 commentable issues. The broken link couldn't be inline-suggested because the line sits between GitHub diff hunks, so I described it in the review summary.

I also noted that the changelog checkbox is unchecked in the PR body — for a new feature landing in 2026.5.0, consider adding a changelog entry.

github run

@jiulingz jiulingz force-pushed the jolin/local-emergency-disconnect branch from cfd3793 to a3fe4a9 Compare May 29, 2026 19:02
@jiulingz
Copy link
Copy Markdown
Collaborator Author

/bonk review

1 similar comment
@csujedihy
Copy link
Copy Markdown
Collaborator

/bonk review

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the previous round of feedback. All three fixes have been applied correctly:

  • ✅ Description expanded past the 50-character minimum.
  • ✅ Config key and boolean value wrapped in backticks.
  • ✅ Broken anchor link fixed (#clear-external-emergency-disconnect).
  • ✅ Redirect updated to point to the External Emergency Disconnect section anchor.

I have one remaining suggestion to keep a procedure step fully in imperative mood (line 370). Otherwise this looks ready to merge.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 29, 2026

Submitted the review on PR #31120. Here's a summary:

Acknowledged fixes from the previous round:

  • ✅ Description expanded past the 50-character minimum
  • ✅ Config key and boolean value wrapped in backticks
  • ✅ Broken anchor link fixed (#clear-external-emergency-disconnect)
  • ✅ Redirect updated to point to the External Emergency Disconnect section anchor

One remaining suggestion:

  • emergency-disconnect.mdx:370 — Suggested rephrasing the step to keep it fully in imperative mood: use "remove ... and push" as the leading verbs instead of burying the actions in a "by removing ... and pushing" clause.

Otherwise, the PR looks solid and ready to merge after that minor tweak.

github run

@jiulingz jiulingz force-pushed the jolin/local-emergency-disconnect branch from a3fe4a9 to a7b8e07 Compare May 29, 2026 19:20
@jiulingz jiulingz marked this pull request as ready for review May 29, 2026 19:20
@jiulingz jiulingz requested review from a team, cf-rhett, elithrar and lpraneis as code owners May 29, 2026 19:21
@cloudflare-docs-bot
Copy link
Copy Markdown

cloudflare-docs-bot Bot commented May 29, 2026

Review

❌ Review failed for commit a7b8e07. This is usually a transient error — it will retry on the next push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants