[Cloudflare One] Document local emergency disconnect#31120
Conversation
|
/bonk review |
1 similar comment
|
/bonk review |
There was a problem hiding this comment.
3 issues need fixing before merge — one broken link (cannot inline-suggest because the line sits between diff hunks), one style guide violation, and one formatting fix.
CRITICAL
emergency-disconnect.mdx:~380— Broken internal link anchor. The heading changed to### Clear External Emergency Disconnect, so the link[turn off External Emergency Disconnect](#clear-external-emergency-disconnect-state)should point to#clear-external-emergency-disconnect.
MEDIUM
emergency-disconnect.mdx:370— Use "turn off" instead of "disable" per style guide; also use imperative mood ("push" not "pushing").emergency-disconnect.mdx:280— Config key and boolean value need backticks per text formatting rules.
LOW
emergency-disconnect.mdx:3— Description (38 chars) is below the 50-character minimum.
Note: The PR body leaves the changelog checkbox unchecked. For a new feature landing in 2026.5.0, consider adding a changelog entry so customers can discover it via RSS and Discord.
|
Submitted the review on PR #31120. Here's what I found: 3 issues need fixing before merge:
I posted inline suggestions for the 3 commentable issues. The broken link couldn't be inline-suggested because the line sits between GitHub diff hunks, so I described it in the review summary. I also noted that the changelog checkbox is unchecked in the PR body — for a new feature landing in 2026.5.0, consider adding a changelog entry. |
cfd3793 to
a3fe4a9
Compare
|
/bonk review |
1 similar comment
|
/bonk review |
There was a problem hiding this comment.
Thanks for addressing the previous round of feedback. All three fixes have been applied correctly:
- ✅ Description expanded past the 50-character minimum.
- ✅ Config key and boolean value wrapped in backticks.
- ✅ Broken anchor link fixed (
#clear-external-emergency-disconnect). - ✅ Redirect updated to point to the External Emergency Disconnect section anchor.
I have one remaining suggestion to keep a procedure step fully in imperative mood (line 370). Otherwise this looks ready to merge.
|
Submitted the review on PR #31120. Here's a summary: Acknowledged fixes from the previous round:
One remaining suggestion:
Otherwise, the PR looks solid and ready to merge after that minor tweak. |
a3fe4a9 to
a7b8e07
Compare
Review❌ Review failed for commit |
Summary
Adds documentation for local emergency disconnect feature (RM-29186) landing in 2026.5.0. This feature allows organizations to trigger an emergency disconnect on the device itself, without network access.
Documentation checklist