fix: correct retries.limit description to say retries not attempts#31068
Open
qianzhu18 wants to merge 1 commit into
Open
fix: correct retries.limit description to say retries not attempts#31068qianzhu18 wants to merge 1 commit into
qianzhu18 wants to merge 1 commit into
Conversation
The `retries.limit` property specifies the maximum number of retries, not the total number of attempts. Updated the description and code comment to accurately reflect this behavior. Fixes cloudflare#30627
qianzhu18
requested review from
a team,
celso,
elithrar,
jonesphillip and
mia303
as code owners
github-actions
Bot
added
product:workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StepConfigdescription to say "retries" instead of "attempts" for theretries.limitproperty// The total number of attemptsto// The total number of retries (11 attempts total)The
retries.limitproperty specifies the maximum number of retries, not the total number of attempts. For example,limit: 10means 10 retries (11 attempts total), not 10 attempts.Fixes #30627