fix(boring-sys): localize allocator hooks on Android - #518
Open
deepso7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid weak BoringSSL allocator hooks on Android.
BoringSSL exposes
OPENSSL_memory_alloc,OPENSSL_memory_free, andOPENSSL_memory_get_sizeas weak ELF symbols. Whenboring-sysis linkedinto an Android shared library alongside other native dependencies, these
symbols can be resolved to incompatible process symbols and cause a crash
during BoringSSL initialization.
This change applies an Android-only patch that uses BoringSSL's existing
local null-function-pointer fallback instead. Other platforms retain the
current weak-symbol behavior.
Verification
boring-sysand a downstream UniFFI library foraarch64-linux-android.libcrypto.areports all three allocator hooks asLOCAL OBJECT.arm64 Android device.
SIGSEGV.cargo fmt --all -- --checkpasses.