fix stale initial chat URL on agent switch - #2020
Draft
threepointone wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 46dfa5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
useAgent().getHttpUrl()while a room change is still rendering against the previous PartySocketbasePathbehaviorWhy
On an Agent name change,
useAgentChatcould key a new initial-message request under the new conversation whilegetHttpUrl()still returned the previous socket URL. That sent the previous auth token to the new logical request and cached the old conversation under the new key.Fixes #1864.
Validation
The repo-wide check wrapper attempted to reinstall existing
node_modulesand was declined; its individual checks were run directly. The full typecheck wrapper could not resolvetsgofrom its subprocess PATH, so the affected TypeScript projects were run directly and passed.