Display number of new tests for subset and New column for inspect commands - #1355
Open
takanabe wants to merge 1 commit into
Open
Display number of new tests for subset and New column for inspect commands#1355takanabe wants to merge 1 commit into
takanabe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We want to let the CLI users to know if tests are new and how many new tests are introduced for given subsets. This PR support the feature for subset and inspect commands.
Expected output
Subset command output with this change
We expect an output like below.
(3) new test count in Subset (New Tests) | 18 (3) comes from summary.subset.newTestCount, which this branch added to JSSubsetSummary. The CLI reads that field to render the parenthetical.
Inspect command output with this change
We expect an output like below.
The New column (Yes/No per test) is driven by numNewTests on each OptimizationResult in the inspect response. SubsetDetailService returns the full OptimizationResult objects including numNewTests, so the CLI can check numNewTests > 0 to render Yes/No.
local executions
Subset
Inspect