Move common utils to Coriolis core#449
Open
petrutlucian94 wants to merge 2 commits into
Open
Conversation
The Coriolis providers currently duplicate the code that initializes the backup writers and returns the backup writer connection info. We'll move that along with the corresponding constants to Coriolis core. Coriolis providers are free to define custom backup providers if necessary.
Most providers use a copy of those helpers, which poll until the instance can be accessed using SSH or WINRM. For this reason, we'll move them to the Coriolis core utils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few utility functions that are shared by most providers:
That being considered, we'll move them to Coriolis core, aiming to reduce provider code duplication.