Skip to content

fix(server-nestjs): regenerate sonarqube password when missing - #2421

Merged
shikanime merged 2 commits into
mainfrom
wphetsinorath/push-wnowuovuyqqk
Aug 6, 2026
Merged

fix(server-nestjs): regenerate sonarqube password when missing#2421
shikanime merged 2 commits into
mainfrom
wphetsinorath/push-wnowuovuyqqk

Conversation

@shikanime

@shikanime shikanime commented Aug 5, 2026

Copy link
Copy Markdown
Member

Issues liées

Issues numéro: #2402

Quel est le comportement actuel ?

Quel est le nouveau comportement ?

Cette PR introduit-elle un breaking change ?

Autres informations

@shikanime shikanime added this to the 9.24.0 milestone Aug 5, 2026
@shikanime shikanime self-assigned this Aug 5, 2026
@shikanime shikanime added the enhancement New feature or request label Aug 5, 2026
@shikanime
shikanime requested a review from a team August 5, 2026 15:07
@shikanime
shikanime enabled auto-merge August 5, 2026 15:08
@shikanime
fix(server-nestjs): regenerate sonarqube password when vault secret i…
501922e 
…s missing

Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: Ia8c6c5ec950fed91764d2376650564026a6a6964
@shikanime
fix(server-nestjs): make sonarqube SONAR_PASSWORD required
3b6d1d5 
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: I3cb35b45199fc1cedcb85e7e637d28b26a6a6964
@shikanime
shikanime force-pushed the wphetsinorath/push-wnowuovuyqqk branch from 3b3616d to 3b6d1d5 Compare August 5, 2026 15:14
@github-actions github-actions Bot added the built label Aug 5, 2026
@cloud-pi-native-sonarqube

cloud-pi-native-sonarqube Bot commented Aug 5, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

StephaneTrebel
StephaneTrebel approved these changes Aug 5, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/vault/vault-client.service.ts
@shikanime

shikanime commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

Review: #2421 — fix(server-nestjs): regenerate sonarqube password when missing

Verdict: APPROVE (reviewer agent) — matches StephaneTrebel's prior approval.

Small, correct fix. Adds updateUser to SonarqubeClientService; in the "user exists but vault secret missing" branch it now regenerates a 30-char random password (generateRandomPassword, already used in the create branch) and pushes SONAR_PASSWORD to vault — closing the previously-broken path where the secret was created without a password. SonarqubeUserSecret.SONAR_PASSWORD tightened optional→required. Test updated to assert updateUser + SONAR_PASSWORD. No security/standard issues.

This was referenced Aug 6, 2026
Closed
Draft
Merged
Merged
Draft
@shikanime
shikanime added this pull request to the merge queue Aug 6, 2026
@shikanime
shikanime requested a review from a team August 6, 2026 12:38
Merged via the queue into main with commit 4508631 Aug 6, 2026
34 checks passed
@shikanime
shikanime deleted the wphetsinorath/push-wnowuovuyqqk branch August 6, 2026 12:57
@StephaneTrebel StephaneTrebel linked an issue Aug 7, 2026 that may be closed by this pull request
🐛 [BUG] - Race condition sur les secrets Vault lors du provisionnement concurrent (symptôme : SONAR_PASSWORD = 'not initialized') — server-nestjs #2402
Closed
@shikanime shikanime mentioned this pull request Aug 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel approved these changes

Assignees

@shikanime shikanime

Labels

built enhancement New feature or request

Projects

None yet

Milestone

9.24.0

Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Race condition sur les secrets Vault lors du provisionnement concurrent (symptôme : SONAR_PASSWORD = 'not initialized') — server-nestjs

2 participants

@shikanime @StephaneTrebel