Add tasktiger[cron] extra for croniter and pytz#372
Open
aaroncoville wants to merge 1 commit intocloseio:masterfrom
Open
Add tasktiger[cron] extra for croniter and pytz#372aaroncoville wants to merge 1 commit intocloseio:masterfrom
aaroncoville wants to merge 1 commit intocloseio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extras_require={"cron": ["croniter>=2.0", "pytz>=2024.1"]}tosetup.py.tasktiger.schedule.cron_exprnow raises a clearImportErrorpointing users atpip install tasktiger[cron]when either dependency is missing (previously a basicModuleNotFoundError).tasktiger[cron]install path in thecron_exprsection ofREADME.rst.tests/test_schedule_cron.pycovering the happy path and both missing-dependency paths.0.25.1CHANGELOG.mdentry from my earlier PR.Reproduction (before the fix)
Verification (after the fix)
Extras install works end-to-end:
Base install now produces a clear error: