Skip to content

CLJS-3481: support :error, :warning, :off modes with :warnings #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swannodette merged 1 commit into from
May 28, 2026
+20 −12
Merged

CLJS-3481: support :error, :warning, :off modes with :warnings #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/main/clojure/cljs/analyzer.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,12 +484,17 @@
"ambiguous expression " form)))

(defn default-warning-handler [warning-type env extra]
(when (warning-type *cljs-warnings*)
(when-let [s (error-message warning-type extra)]
#?(:clj (binding [*out* *err*]
(println (message env (str "WARNING: " s))))
:cljs (binding [*print-fn* *print-err-fn*]
(println (message env (str "WARNING: " s))))))))
(let [warn-mode (warning-type *cljs-warnings*)]
(when-not (#{false :off} warn-mode)
(when-let [s (error-message warning-type extra)]
(cond
(#{true :warning} warn-mode)
#?(:clj (binding [*out* *err*]
(println (message env (str "WARNING: " s))))
:cljs (binding [*print-fn* *print-err-fn*]
(println (message env (str "WARNING: " s)))))
(= :error warn-mode)
(throw (ex-info s {})))))))

(def ^:dynamic *cljs-warning-handlers*
[default-warning-handler])
Expand Down
15 changes: 9 additions & 6 deletions src/main/clojure/cljs/closure.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3048,15 +3048,18 @@
ana/*load-tests* (not= (:load-tests opts) false)
ana/*cljs-warnings*
(let [warnings (opts :warnings true)]
(merge
ana/*cljs-warnings*
(if (or (true? warnings)
(false? warnings))
(cond
(map? warnings)
(merge ana/*cljs-warnings* warnings)

;; backwards compatible
(or (boolean? warnings)
(keyword? warnings))
(merge ana/*cljs-warnings*
(zipmap
[:unprovided :undeclared-var
:undeclared-ns :undeclared-ns-form]
(repeat warnings))
warnings)))
(repeat warnings)))))
ana/*verbose* (:verbose opts)]
(when (and ana/*verbose* (not (::watch-triggered-build? opts)))
(util/debug-prn "Options passed to ClojureScript compiler:" (pr-str opts)))
Expand Down
Loading