Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project toolchain and build/CI flow by migrating Calcit manifests to deps.cirru, moving to Yarn 4 (Corepack), and updating the frontend build stack (Vite) plus GitHub Actions integration.
Changes:
- Replace legacy Calcit manifests (
calcit.cirru,package.cirru) withdeps.cirruand bump Calcit CLI/procs versions. - Upgrade Yarn lockfile format (Yarn Berry) and Vite, and add Yarn configuration for
node-moduleslinking. - Update CI workflow to use Corepack +
yarn install --immutableand newer Calcit setup action.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Regenerated lockfile for Yarn Berry and updated dependency graph (incl. Vite/Calcit upgrades). |
package.json |
Adds packageManager + build scripts; upgrades vite and @calcit/procs. |
package.cirru |
Removes legacy dependency manifest. |
deps.cirru |
Adds new Calcit deps/config manifest (init/reload fns, pinned Calcit deps). |
calcit.cirru |
Removes legacy Calcit manifest/source bundle. |
.yarnrc.yml |
Configures Yarn to use node-modules linker. |
.gitignore |
Ignores macOS .DS_Store and some Yarn artifacts. |
.github/workflows/upload.yaml |
Updates CI to Corepack + immutable installs and newer Calcit setup action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "devDependencies": { | ||
| "bottom-tip": "^0.1.5", | ||
| "vite": "^6.4.2" | ||
| "vite": "^8.0.8" | ||
| }, |
There was a problem hiding this comment.
bottom-tip is imported from application runtime code (see compact.cirru), so keeping it under devDependencies can break builds in environments that install production deps only (e.g., yarn install --production) or confuse dependency intent. Move it to dependencies (and keep only build tooling like vite in devDependencies).
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Done in 0e82786 — moved bottom-tip from devDependencies to dependencies in package.json so runtime imports are available in production installs.
Agent-Logs-Url: https://github.com/clojure-china/map.clojure-china.org/sessions/c49b93b5-e5d8-43f0-a11e-bc381f0264e1 Co-authored-by: tiye <449224+tiye@users.noreply.github.com>
Summary
Validation