Add view metrics that are separate from reducer metrics #5553
Merged
Conversation
gefjon
reviewed
Jul 15, 2026
Co-authored-by: Phoebe Goldman <phoebe@goldman-tribe.org> Signed-off-by: Jeffrey Dallatezza <jeffreydallatezza@gmail.com>
gefjon
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Right now we have views and reducers sharing some metrics (
reducer_wasm_time_usecandreducer_wasmtime_fuel_used), which makes it difficult to tell whether we are spending time on views or actual reducers.We are counting all of the time reported for views to the reducer that triggered it (which is also misleading). This change adds some view-specific metrics, and it adds a stat for how many view calls were triggered by each reducer.
I changed the existing behaviour to remove the double-counting, but I did not remove the code that reports to
reducer_wasm_time_usecandreducer_wasmtime_fuel_usedwith the view name as a label, because I'd like to get this change in before I check whether removing those would affect customer visible dashboards.I will follow up with something to remove the misleading stats once I verify that we can.
Expected complexity level and risk
Testing
This doesn't have any testing.