Skip to content

Add IntoIterator implementations for ProductType#5543

Draft
samrusani wants to merge 1 commit into
clockworklabs:masterfrom
samrusani:agent/product-type-into-iterator
Draft

Add IntoIterator implementations for ProductType#5543
samrusani wants to merge 1 commit into
clockworklabs:masterfrom
samrusani:agent/product-type-into-iterator

Conversation

@samrusani

Copy link
Copy Markdown

Description of Changes

Closes #1452.

  • Implement consuming iteration for ProductType.
  • Implement borrowed iteration for &ProductType.
  • Use the new consuming iterator in the existing product-value generator and layout builder.
  • Add a unit test covering both iterator forms.

API and ABI breaking changes

None. These are additive trait implementations with no runtime or ABI changes.

Expected complexity level and risk

  1. This is a small, backward-compatible refactor localized to spacetimedb-sats.

Testing

  • cargo fmt --all -- --check
  • cargo test -p spacetimedb-sats
  • cargo clippy -p spacetimedb-sats --all-targets -- -D warnings
  • git diff --check

@CLAassistant

CLAassistant commented Jul 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@samrusani samrusani force-pushed the agent/product-type-into-iterator branch from 7df6237 to 23282ac Compare July 15, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: add IntoIterator for ProductType and IntoIterator for &ProductType

2 participants