Use pnpm.cmd on Windows in typescript-test#5539
Open
rekhoff wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes: #4969
Fixes
cargo ci typescript-testto work on Windows by using the correctpnpmexecutable name.On Windows,
pnpmis installed aspnpm.cmd(a batch file shim) rather than a barepnpmexecutable. Thecmd!macro from theductcrate invokes executables directly without shell resolution, so calling"pnpm"on Windows fails with "program not found". This adds apnpmhelper that returns"pnpm.cmd"on Windows and"pnpm"elsewhere, and updates allcmd!("pnpm", ...)call sites to use it.API and ABI breaking changes
No API or ABI changes. This is a CI change only.
Expected complexity level and risk
1 - Trivial
Testing
cargo ci typescript-testbefore and after changes, to confirm this resolves local Windows issues.