ci: pin s3-upload-action to a full commit SHA#5538
Merged
Conversation
benchmarks.yml, package.yml and docs-publish.yaml hand shallwefootball/s3-upload-action live AWS credentials (and package.yml's build-cli job also holds DigiCert code-signing secrets) via the mutable @master branch. Pin to the commit @master resolves to so the code that runs with those secrets is fixed. Behaviour unchanged.
|
|
Contributor
|
@kobihikri Why |
Collaborator
this is the current head of master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
shallwefootball/s3-upload-actioninbenchmarks.yml,package.ymlanddocs-publish.yamlfrom the mutable@masterbranch to the commit it resolves to (4 usages).Why
Those steps are handed
AWS_KEY_ID/AWS_SECRET_ACCESS_KEYdirectly as inputs, andpackage.yml'sbuild-clijob additionally holds DigiCert code-signing secrets.@masteris a moving branch, so the exact third-party code that receives those secrets can change without any change here — the tj-actions/changed-files class of risk. Pinning to a full SHA closes that; behaviour unchanged.I used AI assistance to identify this and draft the change; I verified it against the live workflows myself.