Godot Blackholio completion#5030
Open
lisandroct wants to merge 11 commits into
Open
Conversation
lisandroct
force-pushed
the
lisandro/godot-blackholio-completion
branch
from
d9a4371 to
0c10ba6
Compare
lisandroct
force-pushed
the
lisandro/godot-blackholio-completion
branch
2 times, most recently
from
af82eb5 to
c2f7cb9
Compare
lisandroct
force-pushed
the
lisandro/godot-blackholio-completion
branch
from
c2f7cb9 to
562bb5d
Compare
lisandroct
force-pushed
the
lisandro/godot-blackholio-completion
branch
from
562bb5d to
32fae12
Compare
bfops
reviewed
May 28, 2026
| <PackageOutputPath>bin~/$(Configuration)/</PackageOutputPath> | ||
| <BaseIntermediateOutputPath>obj~/godot/</BaseIntermediateOutputPath> | ||
| <IntermediateOutputPath>obj~/godot/$(Configuration)/$(TargetFramework)/</IntermediateOutputPath> | ||
| <UseLocalBsatnRuntime Condition="'$(UseLocalBsatnRuntime)' == ''">false</UseLocalBsatnRuntime> |
Collaborator
There was a problem hiding this comment.
I think we determined that this didn't actually fix the flakiness, is that right?
bfops
reviewed
May 28, 2026
| permissions: | ||
| contents: read | ||
| runs-on: spacetimedb-new-runner-2 | ||
| timeout-minutes: 30 |
Collaborator
There was a problem hiding this comment.
how long does a typical successful run take?
Collaborator
There was a problem hiding this comment.
FWIW we usually only add this when we've had issues with a job hanging
bfops
reviewed
May 28, 2026
Comment on lines
+720
to
+721
| # Run cheap .NET setup first. If that fails, no need to run expensive Godot tests. | ||
|
|
Collaborator
There was a problem hiding this comment.
I don't think this comment makes any sense? the dotnet setup is required for tests, isn't it?
Suggested change
| # Run cheap .NET setup first. If that fails, no need to run expensive Godot tests. |
bfops
reviewed
May 28, 2026
|
|
||
| - name: Build Godot .NET project | ||
| working-directory: demo/Blackholio/client-godot | ||
| run: dotnet build --no-restore -v normal blackholio.csproj |
bfops
reviewed
May 28, 2026
| - name: Publish godot-tests module to SpacetimeDB | ||
| working-directory: demo/Blackholio/server-rust | ||
| run: | | ||
| spacetime logout && spacetime login --server-issued-login local |
Collaborator
There was a problem hiding this comment.
nit: I think the logout part is redundant now. 1) because it's in an ephemeral runner and 2) because we recently made spacetime login automatically do the logout if needed
Suggested change
| spacetime logout && spacetime login --server-issued-login local | |
| spacetime login --server-issued-login local |
bfops
requested changes
May 28, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
The CI part looks pretty good to me, minus a few small comments. It looks like the CI is failing, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI breaking changes
Expected complexity level and risk
Testing