Update C# sdk to use v3 websocket api#4763
Open
joshua-spacetime wants to merge 3 commits intojoshua/ws/v3from
Open
Update C# sdk to use v3 websocket api#4763joshua-spacetime wants to merge 3 commits intojoshua/ws/v3from
joshua-spacetime wants to merge 3 commits intojoshua/ws/v3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR adds C# SDK support for the
v3.bsatn.spacetimedbWebSocket transport which was added in #4761 and keepsv2as a fallback.v3is just a transport wrapper around already-encoded v2 logical messages:v3first and falls back tov2during handshake when neededv3is negotiated, outbound client messages are batched into a single transport frame256 KiBper framev3server frames are unwrapped into their inner v2 messages and then processed by the existing v2 parse/apply pipeline in orderThis also includes Unity WebGL transport updates so the C# SDK can:
API and ABI breaking changes
None. Existing servers that only support
v2continue to work because the SDK falls back during handshake.Expected complexity level and risk
3
The main risks are:
v2The risk is limited by keeping the existing v2 logical message pipeline intact underneath the new transport layer.
Testing
Integration tests for v3 and v2 fallback