Open
Conversation
coolreader18
force-pushed
the
noa/upd-axum
branch
2 times, most recently
from
9fc8af9 to
2b207bc
Compare
coolreader18
force-pushed
the
noa/upd-axum
branch
from
2b207bc to
d852428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Axum now has what we need out of it for a websocket wrapper, so we no longer need to duplicateNevermind, we know send raw frames, which axum's wrapper does not support. Makes this PR simpler.util/flat_csv.rsandutil/websocket.rs, meaning we have less code to maintain.Expected complexity level and risk
2 - upgrading a dependency is a risk, but looking through the changelog there isn't anything that should affect us.
Testing