Skip to content

feat(ui): increase default button and input height by 2px#9061

Draft
alexcarpenter wants to merge 1 commit into
mainfrom
increase-button-input-size
Draft

feat(ui): increase default button and input height by 2px#9061
alexcarpenter wants to merge 1 commit into
mainfrom
increase-button-input-size

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Jul 1, 2026

Copy link
Copy Markdown
Member

Description

Users reported that buttons and inputs look too small, especially on mobile. Both controls derive their height from vertical padding (no fixed height), so this bumps the default button size (sm) and the input base padding from $1x5 (6px) to a new $1x75 (7px) spacing token, making each control 2px taller (~32px → ~34px) while keeping buttons and inputs matched. The $1x75 token is added to the spacing scale alongside existing granular tokens ($0x25, $3x25, $8x75); the compact xs/md button variants and checkboxes/radios are intentionally left unchanged. This is an additive, backwards-compatible change.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • other: UI sizing tweak

Summary by CodeRabbit

  • New Features
    • Buttons and inputs now have slightly larger default sizing, improving tap targets and usability on mobile devices.
  • Bug Fixes
    • Updated spacing values to support the new sizing across shared UI controls and keep layouts consistent.

@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jul 1, 2026 2:39pm
swingset Ready Ready Preview, Comment Jul 1, 2026 2:39pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a88c92c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 82dd3a82-b402-4b63-a940-6d8e1ea1193d

📥 Commits

Reviewing files that changed from the base of the PR and between 8842511 and a88c92c.

📒 Files selected for processing (4)
  • .changeset/tall-buttons-inputs.md
  • packages/ui/src/foundations/sizes.ts
  • packages/ui/src/primitives/Button.tsx
  • packages/ui/src/primitives/Input.tsx

📝 Walkthrough

Walkthrough

This PR adds a new 1x75 spacing scale token (0.4375rem) to the UI foundations and applies it as horizontal padding for Button's size.xs variant and the shared Input base styles, increasing touch target size by 2px. A changeset documents the patch.

Changes

Spacing Token and Padding Update

Layer / File(s) Summary
New spacing scale token
packages/ui/src/foundations/sizes.ts
Adds a 1x75 entry to spacingScale (0.4375rem, multiplier 1.75) and the corresponding entry to spaceUnits, propagating into derived spacing exports.
Apply token to Button and Input padding
packages/ui/src/primitives/Button.tsx, packages/ui/src/primitives/Input.tsx, .changeset/tall-buttons-inputs.md
Updates Button size.xs and Input base styles to use theme.space.$1x75 instead of $1x5 for horizontal padding, with a changeset recording the patch.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A hop, a stretch, a tiny bit more,
Buttons grow taller than before! 🐇
1x75 hops into the scale,
Fingers land soft, no fumble, no fail.
Two pixels for joy — thump-thump goes my tail!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: increasing default button and input height by 2px.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9061

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9061

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9061

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9061

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9061

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9061

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9061

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9061

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9061

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9061

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9061

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9061

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9061

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9061

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9061

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9061

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9061

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9061

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9061

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9061

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9061

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9061

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9061

commit: a88c92c

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-07-01T14:40:46.994Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on a88c92c.

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@alexcarpenter alexcarpenter marked this pull request as draft July 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants