Skip to content

feat(expo): add Expo SDK 56 support#8517

Open
BjornMelin wants to merge 2 commits into
clerk:mainfrom
BjornMelin:feat/expo-sdk-56-support
Open

feat(expo): add Expo SDK 56 support#8517
BjornMelin wants to merge 2 commits into
clerk:mainfrom
BjornMelin:feat/expo-sdk-56-support

Conversation

@BjornMelin
Copy link
Copy Markdown

@BjornMelin BjornMelin commented May 11, 2026

Description

Adds Expo SDK 56 support for the Expo packages while keeping the diff limited to compatibility metadata:

  • expands @clerk/expo and @clerk/expo-passkeys Expo peer ranges to accept SDK 56 preview and stable 56 releases while excluding SDK 57 preview and stable releases with <57.0.0-0;
  • leaves the existing Expo-related dev dependency ranges unchanged, so this PR does not become an internal validation-runtime upgrade;
  • keeps the package README prerequisite wording broad (Expo 53 or later);
  • adds a changeset for both packages.

I did not find an existing issue or PR for Expo SDK 56 support. This follows the same package-scope pattern as prior Expo SDK support PRs, with the additional @clerk/expo-passkeys peer range update because that package was still capped below SDK 55.

Validation run:

  • pnpm install --lockfile-only --engine-strict=false --prefer-offline
  • pnpm install --engine-strict=false
  • pnpm dlx semver 56.0.0-preview.7 -r '>=53 <56 || >=56.0.0-preview.0 <57.0.0-0'
  • pnpm dlx semver 56.0.0 -r '>=53 <56 || >=56.0.0-preview.0 <57.0.0-0'
  • verified 57.0.0-preview.1 and 57.0.0 are excluded by the same range
  • pnpm --filter @clerk/expo lint exits 0; existing warnings remain
  • pnpm --filter @clerk/expo test
  • pnpm --filter @clerk/expo build
  • pnpm --filter @clerk/expo format:check
  • pnpm --filter @clerk/expo-passkeys lint exits 0; existing warnings remain
  • pnpm --filter @clerk/expo-passkeys build
  • pnpm --filter @clerk/expo-passkeys format:check
  • pnpm changeset status --since=upstream/main
  • git diff --check
  • packed local tarballs for both packages, installed them into a minimal Expo SDK 56 fixture with expo@56.0.0-preview.7, react@19.2.3, react-native@0.85.3, and current SDK 56 Expo modules, then ran pnpm --dir /tmp/clerk-expo-sdk56-fixture exec expo install --check

Notes:

  • I intentionally did not bump the packages' Expo dev dependencies. The public support contract is the peer range, and the existing optional Expo module peer ranges already accept the SDK 56 module versions.
  • I did not run full root pnpm test / pnpm build; the PR is scoped to the Expo packages.
  • I did not run native iOS/Android app builds. Expo SDK 56 is currently a preview line, so maintainers may still want device/build-farm validation before release.
  • No JSDoc export changes were needed because this does not add or change public APIs.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports (not applicable: no package exports changed)
  • (If applicable) Documentation has been updated (not applicable: package README wording remains broad and no clerk-docs changes are required for peer metadata)

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copilot AI review requested due to automatic review settings May 11, 2026 15:35
@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

@BjornMelin is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

🦋 Changeset detected

Latest commit: ab71f8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/expo Minor
@clerk/expo-passkeys Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds Expo SDK 56 preview support to @clerk/expo and @clerk/expo-passkeys. A changeset declares minor version bumps for both packages. The peerDependencies.expo ranges in both package.json files are widened to include Expo >=56.0.0-preview.0 <57.0.0-0 while retaining the existing >=53 <56 range.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding Expo SDK 56 support to the Expo packages, which is the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly details the changes: expanding Expo peer dependency ranges to support SDK 56 preview and stable releases, the specific semver ranges used, changesets added, and comprehensive validation performed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the @clerk/expo and @clerk/expo-passkeys packages to advertise and validate compatibility with Expo SDK 56 (including the SDK 56 preview line), primarily through peer range expansions, devDependency validation updates, and README prerequisite updates.

Changes:

  • Expand expo peer dependency ranges to include SDK 56 preview/stable while intending to exclude SDK 57.
  • Refresh Expo-related devDependencies used for SDK validation (including aligning react-native to the SDK 56 preview requirement).
  • Update READMEs and add a changeset to release both packages.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/expo/README.md Updates documented Expo SDK prerequisite range.
packages/expo/package.json Updates Expo validation devDependencies and expands Expo peer range.
packages/expo-passkeys/README.md Updates documented Expo SDK prerequisite range.
packages/expo-passkeys/package.json Updates Expo devDependency and expands Expo peer range.
.changeset/sdk-56-expo-support.md Adds release notes and bumps for the SDK 56 support update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/expo/package.json Outdated
Comment thread packages/expo-passkeys/package.json Outdated
BjornMelin added a commit to BjornMelin/javascript that referenced this pull request May 11, 2026
@BjornMelin BjornMelin force-pushed the feat/expo-sdk-56-support branch from db45e0e to b7fe5d8 Compare May 11, 2026 16:03
@BjornMelin BjornMelin changed the title chore(expo): add Expo SDK 56 support feat(expo): add Expo SDK 56 support May 11, 2026
@BjornMelin BjornMelin force-pushed the feat/expo-sdk-56-support branch from b7fe5d8 to 414555d Compare May 11, 2026 16:07
@BjornMelin
Copy link
Copy Markdown
Author

@coderabbitai resume

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

✅ Actions performed

Reviews resumed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants