feat(expo): add Expo SDK 56 support#8517
Conversation
|
@BjornMelin is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🦋 Changeset detectedLatest commit: ab71f8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThis PR adds Expo SDK 56 preview support to Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the @clerk/expo and @clerk/expo-passkeys packages to advertise and validate compatibility with Expo SDK 56 (including the SDK 56 preview line), primarily through peer range expansions, devDependency validation updates, and README prerequisite updates.
Changes:
- Expand
expopeer dependency ranges to include SDK 56 preview/stable while intending to exclude SDK 57. - Refresh Expo-related devDependencies used for SDK validation (including aligning
react-nativeto the SDK 56 preview requirement). - Update READMEs and add a changeset to release both packages.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/expo/README.md | Updates documented Expo SDK prerequisite range. |
| packages/expo/package.json | Updates Expo validation devDependencies and expands Expo peer range. |
| packages/expo-passkeys/README.md | Updates documented Expo SDK prerequisite range. |
| packages/expo-passkeys/package.json | Updates Expo devDependency and expands Expo peer range. |
| .changeset/sdk-56-expo-support.md | Adds release notes and bumps for the SDK 56 support update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
db45e0e to
b7fe5d8
Compare
b7fe5d8 to
414555d
Compare
|
@coderabbitai resume |
✅ Actions performedReviews resumed. |
Description
Adds Expo SDK 56 support for the Expo packages while keeping the diff limited to compatibility metadata:
@clerk/expoand@clerk/expo-passkeysExpo peer ranges to accept SDK 56 preview and stable 56 releases while excluding SDK 57 preview and stable releases with<57.0.0-0;Expo 53 or later);I did not find an existing issue or PR for Expo SDK 56 support. This follows the same package-scope pattern as prior Expo SDK support PRs, with the additional
@clerk/expo-passkeyspeer range update because that package was still capped below SDK 55.Validation run:
pnpm install --lockfile-only --engine-strict=false --prefer-offlinepnpm install --engine-strict=falsepnpm dlx semver 56.0.0-preview.7 -r '>=53 <56 || >=56.0.0-preview.0 <57.0.0-0'pnpm dlx semver 56.0.0 -r '>=53 <56 || >=56.0.0-preview.0 <57.0.0-0'57.0.0-preview.1and57.0.0are excluded by the same rangepnpm --filter @clerk/expo lintexits 0; existing warnings remainpnpm --filter @clerk/expo testpnpm --filter @clerk/expo buildpnpm --filter @clerk/expo format:checkpnpm --filter @clerk/expo-passkeys lintexits 0; existing warnings remainpnpm --filter @clerk/expo-passkeys buildpnpm --filter @clerk/expo-passkeys format:checkpnpm changeset status --since=upstream/maingit diff --checkexpo@56.0.0-preview.7,react@19.2.3,react-native@0.85.3, and current SDK 56 Expo modules, then ranpnpm --dir /tmp/clerk-expo-sdk56-fixture exec expo install --checkNotes:
pnpm test/pnpm build; the PR is scoped to the Expo packages.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change