Invalidate session affinity on auth-wide failures and force fresh upstream sessions#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Manager.MarkResultto detect auth-wide unavailability and triggerinvalidateSessionAffinityForAuth, which callsInvalidateAuthon active affinity selectors.SessionCachewith aforceNewmap andConsumeForceNewmethod;InvalidateAuthnow records recently unbound sessions intoforceNewso callers can detect the need for a fresh upstream session.SessionAffinitySelectorand manager affinity-based pick paths to consultConsumeForceNewfor primary and fallback session keys and callforceNewUpstreamSessionForNextCredentialwhen necessary to start a fresh upstream session.TestManager_AuthWideFailureInvalidatesAffinityAndForcesFreshSessionto validate that auth-wide failures clear affinity bindings and cause the next execution to force a new upstream session and rebind to a different auth.Testing
go test ./sdk/cliproxy/auth -run TestManager_AuthWideFailureInvalidatesAffinityAndForcesFreshSessionand related affinity tests, and they passed.conductor_overrides_test.gowere executed and continued to succeed after the changes.SessionCachecleanup behavior via unit tests and ensuredConsumeForceNewentries expire correctly during cache cleanup.Codex Task