Tightens type-checking for Transform#80
Merged
Merged
Conversation
Tomaz-Vieira
force-pushed
the
tighter_typing
branch
from
July 15, 2026 10:59
4897f24 to
96d7496
Compare
clbarnes
approved these changes
Jul 15, 2026
Owner
|
Thanks! I know there are a bunch of wonky type annotations around conversions between different array types too. To my mind, the whole purpose of the array API should be to provide a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transformwas missing a few type arguments that were makingpyrightunhappy; it was assuming that the return type ofTransform.invertwasTransform[Unknown].