fix: refactor MachO to remove leak - #236
Open
lilfer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
Resolves a memory leak caused by using
Box::leakin Mach-O manipulation routines.Problem
MachOcan't both own bothMachFileand the binary buffer it borrows without self-referencing, so the previous implementation leaked the buffer to satisfy the'staticlifetime.MachOExtcalledself.data = Box::leak(...)each time binary load commands were modified.This caused memory accumulation over time when performing repeated signing operations.
Changes
MachOto storedata: Vec<u8>instead ofMachFile<'static>, dynamically parsingMachFile<'_>on demand inmacho_file(&self).MachOExtmethods to return the modified data instead of mutating and leaking it.modify_binarieshelper inMachOto apply closures and updateself.data. Since every edit already wrote to disk, I removedwrite_changesand merged it into this helper, but with this setup it should be easy to instead chain edits before saving.