fix(kubernetes): stop scoping marketplace app list to the target region - #600
Merged
Merged
Conversation
ListDefaultApps/CheckAPPName call the global /v2/kubernetes/applications catalogue, but civogo's sendRequest tacks the client's Region onto every GET as a query param. Since #582 removed the hardcoded nyc1 override, the call now sends the user's real --region, which 404s with database_region_not_found for any region the marketplace backend doesn't know about (e.g. jkt1) -- aborting `civo kubernetes create` before the cluster is ever requested, even though the region itself is valid for cluster creation. Clear the region explicitly for this catalogue call instead of relying on whatever region the client happens to be configured with. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
toolchain go1.26.6 resolves the crypto/tls, net/url, net/http/idna, and encoding/asn1 stdlib CVEs; golang.org/x/image v0.45.0 resolves the vp8l/webp/tiff decoding CVEs.
giornetta
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
civo kubernetes createunconditionally callsListDefaultApps()to build the default marketplace-app list before creating the clustersendRequestappends?region=<client.Region>to every request; fix: remove hardcoded nyc1 region from marketplace app queries #582 removed the hardcodednyc1override on this call, so it now sends the cluster's real target regionjkt1),/v2/kubernetes/applications404s withdatabase_region_not_found, aborting cluster creation entirely even though the region is valid for the cluster itself (CheckAvailability,GetDefaultNetwork, andNewKubernetesClustersall succeed with that same region)Test plan
go build ./...go test ./utility/...civo kubernetes create <name> -s g4s.kube.xsmall -t default -n 1 --region jkt1on a config where the marketplace backend doesn't recognize the region — confirm cluster creation no longer fails at the apps-listing step🤖 Generated with Claude Code