Skip to content

libdvi: halt in RAM instead of flash-resident panic() in DMA IRQ #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikeysklar wants to merge 1 commit into from
+8 −2
Closed

libdvi: halt in RAM instead of flash-resident panic() in DMA IRQ #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions software/libdvi/dvi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,14 @@ static void __dvi_func(dvi_dma_irq_handler)(struct dvi_inst *inst) {
// now have until the end of this region to generate DMA blocklist for next
// scanline.
dvi_timing_state_advance(inst->timing, &inst->timing_state);
if (inst->tmds_buf_release && !queue_try_add_u32(&inst->q_tmds_free, &inst->tmds_buf_release))
panic("TMDS free queue full in IRQ!");
if (inst->tmds_buf_release && !queue_try_add_u32(&inst->q_tmds_free, &inst->tmds_buf_release)) {
// Would be a bug ("TMDS free queue full in IRQ"). Hang here rather
// than panic(): panic is flash-resident, and core1 may run with
// flash access disabled (e.g. CircuitPython's MPU lockout), where
// calling into flash hard faults before anything is printed.
while (true)
tight_loop_contents();
}
inst->tmds_buf_release = inst->tmds_buf_release_next;
inst->tmds_buf_release_next = NULL;

Expand Down