fix(quake): prepare local service volume dirs#52
Open
giwaov wants to merge 1 commit intocirclefin:mainfrom
Open
fix(quake): prepare local service volume dirs#52giwaov wants to merge 1 commit intocirclefin:mainfrom
giwaov wants to merge 1 commit intocirclefin:mainfrom
Conversation
bastienfaivre
approved these changes
May 4, 2026
Comment on lines
343
to
344
| /// Create EL data dirs and set directory permissions so containers (running as non-root user arc) | ||
| /// can write to mounted volumes. Required on Linux where bind-mount permissions are strict. |
There was a problem hiding this comment.
This comment needs a slight adjustment due to the changes made.
Suggested change
| /// can write to mounted volumes. Required on Linux where bind-mount permissions are strict. | |
| /// Create EL data dirs and set directory permissions so containers (running as non-root user) | |
| /// can write to mounted volumes. Required on Linux where bind-mount permissions are strict. |
| ] { | ||
| assert!(path.is_dir(), "expected {} to exist", path.display()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Extend the test to also verify that the directories have the correct permissions.
Suggested change
| } | |
| #[cfg(unix)] | |
| { | |
| use std::os::unix::fs::PermissionsExt; | |
| let writable_dirs = [ | |
| testnet_dir.join("logs"), | |
| monitoring_dir.join("data").join("grafana"), | |
| monitoring_dir.join("data").join("prometheus"), | |
| testnet_dir.join("blockscout").join("logs"), | |
| testnet_dir.join("blockscout").join("dets"), | |
| ]; | |
| for path in &writable_dirs { | |
| let mode = fs::metadata(path).unwrap().permissions().mode() & 0o777; | |
| assert_eq!(mode, 0o777, "{} mode = {:o}, want 0o777", path.display(), mode); | |
| } | |
| } | |
| } |
hvanz
requested changes
May 4, 2026
Comment on lines
+353
to
+356
| monitoring_dir.join("data").join("grafana"), | ||
| monitoring_dir.join("data").join("prometheus"), | ||
| testnet_dir.join("blockscout").join("logs"), | ||
| testnet_dir.join("blockscout").join("dets"), |
There was a problem hiding this comment.
Monitoring directories should not be created here. There's a setup method in MonitoringManager for that.
Author
|
Thanks, fixed. I moved the monitoring data dir creation/permissions into MonitoringManager::setup() and kept set_local_testnet_directory_permissions() focused on the local testnet/blockscout/node volume dirs. Also added a focused test for the monitoring setup path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32
Testing
cargo +1.93 fmt --checkI also tried
cargo +1.93 check -p quake --bin quake, but this Windows environment is missinglibclangforreth-mdbx-sys, so the build stops before checking thequaketarget.