Skip to content

Keltner Channel Strategy added. Issue 339#362

Merged
cinar merged 2 commits into
cinar:masterfrom
whencanibe:keltner-channel-strategy
May 25, 2026
Merged

Keltner Channel Strategy added. Issue 339#362
cinar merged 2 commits into
cinar:masterfrom
whencanibe:keltner-channel-strategy

Conversation

@whencanibe
Copy link
Copy Markdown
Contributor

Describe Request

Implements the Keltner Channel Strategy as requested in issue #339.

The Keltner Channel indicator already exists in the volatility package. This PR adds the strategy layer on top of it, following the existing patterns in strategy/volatility.

Fixed #339

Change Type

New strategy.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 24, 2026

Codecov Report

❌ Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.24%. Comparing base (894947f) to head (40a381a).

Files with missing lines Patch % Lines
strategy/volatility/volatility.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   93.21%   93.24%   +0.03%     
==========================================
  Files         219      220       +1     
  Lines        6311     6355      +44     
==========================================
+ Hits         5883     5926      +43     
- Misses        347      348       +1     
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cinar
Copy link
Copy Markdown
Owner

cinar commented May 25, 2026

Thank you very much for your contribution. If you can sign your commit, I will be able to merge it. Otherwise the repo policy is not allowing me to do so. Otherwise, your changes are all good.

Signed-off-by: Eonyak Cho <eonyakcho@gmail.com>
@whencanibe whencanibe force-pushed the keltner-channel-strategy branch from df58fd0 to 5ce679f Compare May 25, 2026 19:00
@whencanibe
Copy link
Copy Markdown
Contributor Author

Hi, Thank you for reviewing my PR.
I have signed the commit with my GPG key. Could you please take another look? Thank you!

Signed-off-by: Onur Cinar <onur.cinar@gmail.com>
@cinar
Copy link
Copy Markdown
Owner

cinar commented May 25, 2026

Thank you very much!

@cinar cinar merged commit cee4c95 into cinar:master May 25, 2026
2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Keltner Channel Strategy

3 participants