Skip to content

Donchian Channel Breakout Strategy added. Issue 338#361

Merged
cinar merged 3 commits into
cinar:masterfrom
whencanibe:donchian-channel-breakout-strategy
May 25, 2026
Merged

Donchian Channel Breakout Strategy added. Issue 338#361
cinar merged 3 commits into
cinar:masterfrom
whencanibe:donchian-channel-breakout-strategy

Conversation

@whencanibe
Copy link
Copy Markdown
Contributor

Describe Request

Implements the Donchian Channel Breakout Strategy as requested in issue #338.

The Donchian Channel indicator already exists in the volatility package.
This PR adds the strategy layer on top of it, following the existing patterns in strategy/volatility.

Fixed #338

Change Type

New strategy.

Signed-off-by: Eonyak Cho <eonyakcho@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 24, 2026

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.21%. Comparing base (0ec4196) to head (9ffcc79).

Files with missing lines Patch % Lines
strategy/volatility/volatility.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   93.18%   93.21%   +0.02%     
==========================================
  Files         218      219       +1     
  Lines        6269     6311      +42     
==========================================
+ Hits         5842     5883      +41     
- Misses        346      347       +1     
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cinar
Copy link
Copy Markdown
Owner

cinar commented May 25, 2026

Thank you very much for the contribution! I am unable to merge it as your commit is not signed. If you can sign your commit through your GPG key, the system will let me to merge it.

@cinar cinar merged commit 894947f into cinar:master May 25, 2026
2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Donchian Channel Breakout Strategy

3 participants