Donchian Channel Breakout Strategy added. Issue 338#361
Merged
cinar merged 3 commits intoMay 25, 2026
Conversation
Signed-off-by: Eonyak Cho <eonyakcho@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 93.18% 93.21% +0.02%
==========================================
Files 218 219 +1
Lines 6269 6311 +42
==========================================
+ Hits 5842 5883 +41
- Misses 346 347 +1
Partials 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thank you very much for the contribution! I am unable to merge it as your commit is not signed. If you can sign your commit through your GPG key, the system will let me to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Request
Implements the Donchian Channel Breakout Strategy as requested in issue #338.
The Donchian Channel indicator already exists in the
volatilitypackage.This PR adds the strategy layer on top of it, following the existing patterns in
strategy/volatility.Fixed #338
Change Type
New strategy.