Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
IvanHargreaves
left a comment
IvanHargreaves
left a comment
There was a problem hiding this comment.
Great progress, just a few things I've spotted in comments. Thx.
| jobs: | ||
|
|
||
| build-mvnw: | ||
| name: Build Maven Wrapper |
There was a problem hiding this comment.
GitHub web-ui isn't particularly good for delta changes. It looks like you've made some good updates, but I don't see the normal gradle and maven build-paths here, only gradlew, so I think they need adding back.
There was a problem hiding this comment.
yeah,right,made the changes
|
|
||
|
|
||
| <!-- | ||
| Publishes artifacts to here if the deploy goal is used. |
There was a problem hiding this comment.
I think we can remove this publish section. I'm not sure how it got here originally or what the purpose was relating to this sample. Unless someone knows the intent/purpose, it can be removed.
There was a problem hiding this comment.
sure,done,was supposed to remove this one,missed it
| // ============================================================================ | ||
| cicsBundle { | ||
| build { | ||
| defaultJVMServer = project.findProperty('cics.jvmserver') ?: cicsJvmServer |
There was a problem hiding this comment.
The default 'ciicsJvmServer' doesn't look correct. Our default for samples is DFHWLP.
| <parent> | ||
| <groupId>com.ibm.cicsdev</groupId> | ||
| <artifactId>cics-java-liberty-springboot-transactions</artifactId> | ||
| <version>0.1.0</version> |
There was a problem hiding this comment.
I think we were making all the updated (SB3 based) samples consistent with version 1.0.0 now, rather than 0.1.0. There might be other instances where the versions haven't been updated, so please check all that apply.
| cicsBomVersion=6.3-20250905155520 | ||
|
|
||
| # Framework Versions | ||
| jakartaVersion=10.0.0 |
There was a problem hiding this comment.
I don't see where in this delta these variables are being used? Maybe I've missed where they are supposed to be used.
There was a problem hiding this comment.
I intended to use them but didnt use,so I think these can be ignored at the moment.Removed,thanks!
IvanHargreaves
left a comment
IvanHargreaves
left a comment
There was a problem hiding this comment.
Great, just a couple more questions in comments.
| java_version = 17 | ||
|
|
||
| # CICS Configuration | ||
| cicsJvmServer=DFHWLP |
There was a problem hiding this comment.
Is this used? If not it can be removed. Thanks.
| # CICS Configuration | ||
| cicsJvmServer=DFHWLP | ||
|
|
||
| libertyApisVersion=25.0.0.9 No newline at end of file |
There was a problem hiding this comment.
Same here, is it used?
3 participants
created app and bundle modules and made necessary changes ands restructured the entire codebase of this sample