Skip to content

table format for landing page#12

Merged
AaronJhaj merged 4 commits into
mainfrom
cicsdev-landing-page
Jul 9, 2025
Merged

table format for landing page#12
AaronJhaj merged 4 commits into
mainfrom
cicsdev-landing-page

Conversation

@AaronJhaj

@AaronJhaj AaronJhaj commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

table format for landing page - see comment for visual

@AaronJhaj AaronJhaj self-assigned this Jul 8, 2025
@AaronJhaj AaronJhaj requested a review from IvanHargreaves July 8, 2025 14:59
@github-actions

github-actions Bot commented Jul 8, 2025

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@AaronJhaj

Copy link
Copy Markdown
Contributor Author

image

@IvanHargreaves

Copy link
Copy Markdown

@AaronJhaj

  • Java EE and Jakarta EE samples could be merged with (or be a sub-category) of Liberty Samples
  • CICS Explorer SDK Samples might be clearer to say 'Migrated and modernised CICS Explorer SDK samples' - and I presume most of them are also cross-linked from other categories such as the OSGi and Liberty ones?

Otherwise, I'm happy with the groupings.

@AaronJhaj

Copy link
Copy Markdown
Contributor Author

@IvanHargreaves the java EE samples are not all Liberty so i'm not sure if it could be a subset of the Liberty samples?

and yes the OSGi and Liberty samples have crossover with the explorer samples. but again there are several other osgi/liberty samples that are not explorer samples hence the separation

@AaronJhaj

Copy link
Copy Markdown
Contributor Author

image

@jt-nti jt-nti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table looks really smart. Just a minor comment about removing the old content completely.

Comment thread profile/README.md Outdated
@AaronJhaj AaronJhaj requested a review from jt-nti July 9, 2025 10:10
@AaronJhaj

Copy link
Copy Markdown
Contributor Author

Are we happy to merge? @IvanHargreaves @jt-nti

@IvanHargreaves

Copy link
Copy Markdown

Liberty is our Java EE / Jakarta EE environment. If there are samples in those sections which are not Liberty, then they are likely to be misplaced. There is a small hybrid area, JDBC and JNDI which are intrinsic to both. If they are running in the OSGi JVM server we would class them as OSGi and not Java EE.

So I think "Liberty (Java EE / Jakarta EE) Samples" would be the best section title and remove the duplicate reference from the description. Everything else looks good to me!

@AaronJhaj

Copy link
Copy Markdown
Contributor Author

@IvanHargreaves
image

@AaronJhaj AaronJhaj merged commit 990c6c2 into main Jul 9, 2025
1 check passed
@AaronJhaj AaronJhaj deleted the cicsdev-landing-page branch July 9, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants