ci: fix multi-arch manifest for Docker Hub and GHCR#288
Merged
Conversation
Previously each matrix job pushed the same final tags independently, so whichever job finished last silently overwrote the other — leaving only a single-arch manifest under every tag. Now each matrix job pushes a platform-specific temp tag, and a dedicated merge job uses docker buildx imagetools create to assemble the final multi-arch manifest list for both DockerHub and GHCR. Also adds packages: write permission required for GHCR pushes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Each matrix job (amd64 + arm64) was pushing to the exact same final tags. Whichever job finished last silently overwrote the other, leaving every tag pointing to a single-arch manifest.
Solution
build-<run_id>-<platform>) to both registries.mergejob runs after all build jobs complete and usesdocker buildx imagetools createto assemble the correct multi-arch manifest list for all final tags (<version>,<major>,current,latest).packages: writepermission (required for GHCR pushes, was previously missing).