Enhance documentation and fix skill invocation issues#39
Merged
Conversation
…th implementation feat(docs): create plan for fixing skill invocation issues with code-interpreter and arxiv-daily-briefing fix(src): update default system prompt to clarify loading of code-interpreter skill fix(src): modify skill registry to treat skills with model or tools whitelist as subagents
…b.com/chinkan/RustBot into cursor/autopilot-supervisor-plan-0c7b
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses UTF-8 byte-slice panics caused by unsafe string truncation in three Rust modules by introducing a shared, Unicode-safe truncation utility. The changes ensure that truncating strings with multi-byte characters (like Chinese or Japanese) no longer causes runtime panics, and they refactor duplicated logic into a reusable function. The update also adds comprehensive regression tests for multibyte inputs.
Core Improvements:
Bug Fixes for UTF-8 Safety:
&s[..N]) with a new Unicode-aware function, preventing panics on multi-byte characters intool_notifier.rs,rag.rs, andquery_rewriter.rs. [1] [2]Refactoring and Code Reuse:
truncate_charsfunction fromtool_notifier.rsinto a shared utility modulesrc/utils/str.rs, and updates all affected modules to use this shared implementation.src/utils/mod.rs,src/main.rs).Testing and Regression Coverage:
Affected Modules:
src/platform/tool_notifier.rs: Uses shared truncation utility and adds multibyte tests. [1] [2]src/memory/rag.rs: Fixes unsafe truncation and adds a multibyte regression test.src/memory/query_rewriter.rs: Fixes unsafe truncation and adds a multibyte regression test.These changes collectively eliminate a class of production panics on non