Skip to content

Reject NUL bytes in HTTP request lines #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewkernel wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

Reject NUL bytes in HTTP request lines #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cheroot/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,13 @@ def read_request_line(self): # noqa: C901 # FIXME
)
return False

if b'\x00' in request_line:
self.simple_response(
'400 Bad Request',
'Malformed Request-Line',
)
return False

try:
method, uri, req_protocol = request_line.strip().split(SPACE, 2)
if not req_protocol.startswith(b'HTTP/'):
Expand Down
5 changes: 5 additions & 0 deletions cheroot/test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,11 @@ def test_large_request(test_client_with_defaults):
HTTP_BAD_REQUEST,
b'Malformed Request-Line',
),
(
b'GET /\x00 HTTP/1.1', # NUL byte
HTTP_BAD_REQUEST,
b'Malformed Request-Line',
),
(
b'GET / HTTPS/1.1', # invalid proto
HTTP_BAD_REQUEST,
Expand Down
1 change: 1 addition & 0 deletions docs/changelog-fragments.d/832.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Rejected HTTP request lines containing NUL bytes as malformed requests.
Loading