fix(baseline-correction): preserve saved anchors instead of defaults ones - #4323
Open
hamed-musallam wants to merge 1 commit into
Open
fix(baseline-correction): preserve saved anchors instead of defaults ones#4323hamed-musallam wants to merge 1 commit into
hamed-musallam wants to merge 1 commit into
Conversation
Deploying nmrium with
|
| Latest commit: |
f19a05c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://37da0ce5.nmrium.pages.dev |
| Branch Preview URL: | https://fix-baseline-correction-anch.nmrium.pages.dev |
hamed-musallam
force-pushed
the
fix-baseline-correction-anchors
branch
from
August 21, 2026 10:43
f9195aa to
d88e112
Compare
…ones
Anchors are stored as number[], not { x: number[] }, so the existing check always reads undefined and discards saved anchors.
Also avoid overwriting anchors currently being edited on filter/spectrum change.
hamed-musallam
force-pushed
the
fix-baseline-correction-anchors
branch
from
August 21, 2026 10:43
d88e112 to
f19a05c
Compare
hamed-musallam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchors are stored as number[], not { x: number[] }, so the existing check always reads undefined and discards saved anchors. Also avoid overwriting anchors currently being edited on filter/spectrum change.