feat: improve min level determination contours - #4317
Open
jobo322 wants to merge 20 commits into
Open
Conversation
Deploying nmrium with
|
| Latest commit: |
435ec37
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://587d3dc1.nmrium.pages.dev |
| Branch Preview URL: | https://improve-min-level-determinat.nmrium.pages.dev |
hamed-musallam
force-pushed
the
improve_min_level_determination_contours
branch
2 times, most recently
from
August 21, 2026 11:45
f765560 to
5c4570a
Compare
…-based calculations
…ute value independently avoid the use of sanplot if info.noise does not exist
drop unused exports: RidgeScores, AutoContourDiagnostics, ThresholdDiagnostics, erfc, and evaluateRidgeScores are only used within the findBestMinContour module, Also removes computeRidgeScores, createMask, and countActivePixels, which were unused code.
hamed-musallam
force-pushed
the
improve_min_level_determination_contours
branch
from
August 21, 2026 18:51
838bfbe to
adc310d
Compare
hamed-musallam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to take care of T1 noise ridges, like:
this T1-noise does not follow the gaussian distribution of white noise and appear over the noise level.
uses the acquisitionScheme to determine if magnitudeMode should be used for noise level determination when a processed spectra is loaded.