feat: apply processings from panel change#4254
Conversation
fix: spectrum init when it imply `processings` * now it check if originalInfo / originalData exists. Only set them if not exists * disable filters apply if `processings`
…on-operation-change
Deploying nmrium with
|
| Latest commit: |
50821b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b60d7fd.nmrium.pages.dev |
| Branch Preview URL: | https://824-implement-processings-ap.nmrium.pages.dev |
|
I find a lot of issues by playing with the interface but I'm not sure I should report them here. |
fallback to undefined instead null for better compatibility with other methods (like `isSpectrum1D(spectrum: Spectrum | undefined)`). Use generic to infer from `defaultValue`
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
* deep slice spectrum * reorder
https://dev.nmrium.org/#/SamplesDashboard/f209fsf86vo/ViewdatacoffeedatacoffeeCoffeejson 
Do you have an idea of what could cause this issue in my branch @targos ? |
|
What's the issue? |
|
Coffee name don't match, CI expect 1, 2, 3, ... |
|
I don't know, but I guess it's related to the changes in |
|
Solves this issue, but broke processings :/ |
|
coffee file is a very old nmrium file (unversioned), where display holds a name attribute.
Due to nmrium component responsible of spectrum normalization and responsible to run filters. it was not an issue until now. I'l try to understand how core, with read and migrations should be updated to have originalInfo name identical to info name in this context. |
2 participants
fix: spectrum init when it imply
processingsprocessings