Skip to content

Normalize GH workflows#279

Merged
sean-sype-simmons merged 1 commit into
chef:mainfrom
jaymzh:dco
Jul 15, 2026
Merged

Normalize GH workflows#279
sean-sype-simmons merged 1 commit into
chef:mainfrom
jaymzh:dco

Conversation

@jaymzh

@jaymzh jaymzh commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator
  • Add Standalone DCO check
  • Add linters
  • Remove "archived" version of mail-branch-pull-requests
  • add "check all" check

NOTE: When you merge this, please add 'all checks' to required checks for this repo and remove 'dco' and 'expeditor' (they'll be caught by allchecks)

Signed-off-by: Phil Dibowitz phil@ipom.com

@jaymzh
jaymzh requested review from a team as code owners June 13, 2026 02:52
@jaymzh jaymzh changed the title Add standalone DCO Normalize GH workflows Jun 13, 2026
@jaymzh
jaymzh force-pushed the dco branch 3 times, most recently from 72405fa to c7d59d4 Compare June 13, 2026 20:37
@jaymzh
jaymzh requested review from a team as code owners June 13, 2026 20:37
@jaymzh
jaymzh force-pushed the dco branch 2 times, most recently from e578cfd to efe722f Compare July 14, 2026 23:14
checks: read
contents: read
steps:
- uses: wechuli/allcheckspassed@v1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with new recent security 3rd party mesaures, we are required to pin these checks (and others) like so:

wechuli/allcheckspassed@94f72d166474c98e0dfbfbab0e13a7bcdebca002 # v2.2.0

Comment thread .github/workflows/dco.yml
name: DCO Check
steps:
- name: Get PR Commits
uses: actionshub/get-pr-commits@main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actionshub/get-pr-commits@main
uses: actionshub/get-pr-commits@${sha}

@jaymzh

jaymzh commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

@sean-sype-simmons - I've seen those conversions happening, but it has not yet happened in this Repo, none of the other ones are hash-pinned. How about we convert those at once, there's nice tools to do that. Let's not half-convert this repo in this PR and then having someone think it's done, that'd be worse for security.

@jaymzh
jaymzh requested a review from sean-sype-simmons July 15, 2026 17:28
* Add Standalone DCO check
* Add linters
* Remove "archived" version of mail-branch-pull-requests
* add "check all" check

Signed-off-by: Phil Dibowitz <phil@ipom.com>
@sean-sype-simmons
sean-sype-simmons merged commit aeb4d18 into chef:main Jul 15, 2026
36 checks passed
@jaymzh
jaymzh deleted the dco branch July 15, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants