Skip to content

feat(accounts): add ISV payout schedule fields and payment_instrument_id - #230

Merged
armando-rodriguez-cko merged 1 commit into
mainfrom
feat/INT-1684-isv-payout-schedules-links-platforms-instrument
Aug 27, 2026
Merged

feat(accounts): add ISV payout schedule fields and payment_instrument_id#230
armando-rodriguez-cko merged 1 commit into
mainfrom
feat/INT-1684-isv-payout-schedules-links-platforms-instrument

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
Adds the 2026-08-05 spec changes: the ISV (SaaS seller) payout schedule fields balance_minimum and carry_forward_enabled, plus payment_instrument_id which was present in the spec but missing from the SDK. Includes characterization tests pinning the payout schedule GET response shape and frequency serialization the API actually uses.

Changes

  • Payout schedule request/response models: new optional balance_minimum, carry_forward_enabled, payment_instrument_id
  • ISV constraints documented on the existing frequency types (working days only for weekly and daily; monthly accepts only [1], [15], [1,15] or [1,16]); no parallel Isv classes because the wire format is identical
  • Serialization tests: fields present when set, absent when unset; spec-shape characterization tests

API Reference

  • GET /accounts/entities/{id}/payout-schedules
  • PUT /accounts/entities/{id}/payout-schedules

Breaking changes
None.

README
No README impact.

@agent-wall-e

agent-wall-e Bot commented Aug 27, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change only adds optional fields and comments to existing request/response model classes without introducing new endpoints, persisted data, auth changes, external integrations, or background processes.

Operational gates

  • ✅ jira_ticket (INT-1684)
  • ✅ independent_review

Files analysed: 2


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Aug 27, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extensionThe change only adds optional fields and comments to existing request/response model classes without introducing new endpoints, persisted data, auth changes, external integrations, or background processes. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The diff only adds optional fields and documentation comments to existing request/response model classes without introducing new endpoints, persisted data, auth changes, external integrations, or new abstractions.

wall-e 2026.06.19-02 · policy 376219bc71e6…

@armando-rodriguez-cko
armando-rodriguez-cko force-pushed the feat/INT-1684-isv-payout-schedules-links-platforms-instrument branch from 377984c to a947f58 Compare August 27, 2026 10:36
@agent-wall-e

agent-wall-e Bot commented Aug 27, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The diff only adds optional fields to existing request/response models and documentation comments on existing classes, reusing existing endpoints and abstractions without new external integrations, persisted data, auth changes, or new code paths.

Operational gates

  • ✅ jira_ticket (INT-1684)
  • ✅ independent_review

Files analysed: 2


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Aug 27, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extensionThe diff only adds optional fields to existing request/response models and documentation comments on existing classes, reusing existing endpoints and abstractions without new external integrations, persisted data, auth changes, or new code paths. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team August 27, 2026 11:36
@armando-rodriguez-cko
armando-rodriguez-cko merged commit 85b1c5a into main Aug 27, 2026
4 checks passed
@armando-rodriguez-cko
armando-rodriguez-cko deleted the feat/INT-1684-isv-payout-schedules-links-platforms-instrument branch August 27, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants