docs(traceroute): note the protocol-dependent default port (SIM-311)[ship]#1409
Merged
Merged
Conversation
The `port` field's `@defaultValue` said 443 unconditionally, but the default is protocol-dependent: 443 for TCP, 33434 (a closed high port) for UDP/SCTP — the backend applies this when the CLI omits `port`. Doc-only; no behavior change (the construct already sends `undefined` when omitted, letting the backend default govern). Backend/runner fix: checkly/monorepo#3057. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013AYwkvoaANQTH5dGStbBj2
danielpaulus
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up to SIM-311 (backend/runner fix: checkly/monorepo#3057).
The traceroute
portfield's@defaultValueJSDoc said 443 unconditionally, but the default is protocol-dependent:443for TCP and33434(a closed high port) for UDP/SCTP — UDP/SCTP arrival is only confirmed by an ICMP "port unreachable" from a closed port, whereas 443 is typically open and never confirms arrival.Doc-only, no behavior change: the construct already sends
undefinedwhenportis omitted, so the backend's (now protocol-aware) default governs. This just makes the documented default accurate.🤖 Generated with Claude Code