fix(cli): avoid conflicting symlink entries in user code bundles#1408
Open
timohuovinen wants to merge 3 commits into
Open
fix(cli): avoid conflicting symlink entries in user code bundles#1408timohuovinen wants to merge 3 commits into
timohuovinen wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components
Summary
Prevents Playwright user code bundles from containing the same path as both a symlink and a directory with child entries.
When selected files include a symlink and files reached through that symlink, the bundler now omits the conflicting symlink entry and archives the selected child files. This produces an archive that GNU tar can extract successfully while leaving symlinks without selected descendants unchanged.
Test Plan
Run from
packages/cli:pnpm test src/services/check-parser/__tests__/bundler.spec.tspnpm exec eslint src/services/check-parser/bundler.ts src/services/check-parser/__tests__/bundler.spec.ts --no-warn-ignoredpnpm testNotes for the Reviewer
The regression test models a pnpm workspace link selected together with files below it and verifies that the generated tar contains the child files but not the conflicting symlink entry.