refactor: import Autocrypt-Gossip keys without checking the addresses - #8638
Open
link2xt wants to merge 1 commit into
Open
refactor: import Autocrypt-Gossip keys without checking the addresses#8638link2xt wants to merge 1 commit into
link2xt wants to merge 1 commit into
Conversation
link2xt
force-pushed
the
link2xt/autocrypt-gossip-import-no-checks
branch
from
August 28, 2026 21:07
3ff281f to
b75ee18
Compare
It is safe to import any keys into the keychain. Keys can anyway be imported from vCards and Autocrypt headers without any checks. These checks are from the time before we had key-contacts and maintained Autocrypt `peerstates` table.
link2xt
force-pushed
the
link2xt/autocrypt-gossip-import-no-checks
branch
from
August 28, 2026 21:08
b75ee18 to
0092e25
Compare
Collaborator
Author
|
This is from @Hocuri comment at #8620 (comment) |
link2xt
commented
Aug 28, 2026
| @@ -555,8 +555,7 @@ impl MimeMessage { | |||
| // but only if the mail was correctly signed. Probably it's ok to not require | |||
| // encryption here, but let's follow the standard. | |||
Collaborator
Author
There was a problem hiding this comment.
We can probably also drop this check.
Contributor
There was a problem hiding this comment.
autocrypt/gossip and securejoin will need a concerted revisit at some point, but i'd ask for caution now going for "refactors" when they drop checks in this area. Tests still passing after removing checks does not mean much, if the checks were never covered by tests.
link2xt
marked this pull request as ready for review
August 28, 2026 21:14
Hocuri
approved these changes
Aug 29, 2026
hpk42
reviewed
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is safe to import any keys into the keychain.
Keys can anyway be imported from vCards
and Autocrypt headers without any checks.
These checks are from the time before we had key-contacts and maintained Autocrypt
peerstatestable.