Skip to content

fix: Tombstone MDN before sending it (#8252)#8257

Open
iequidoo wants to merge 2 commits into
mainfrom
iequidoo/tombstone-mdn-before-sending
Open

fix: Tombstone MDN before sending it (#8252)#8257
iequidoo wants to merge 2 commits into
mainfrom
iequidoo/tombstone-mdn-before-sending

Conversation

@iequidoo
Copy link
Copy Markdown
Collaborator

@iequidoo iequidoo commented May 20, 2026

Otherwise, when it appears on IMAP, it will mark chat messages as seen/noticed even if
markfresh_chat() is called meanwhile.

test: Add function to queue MDN into smtp is extracted from #8008
Fix #8252

iequidoo added 2 commits May 19, 2026 23:36
Otherwise, when it appears on IMAP, it will mark chat messages as seen/noticed even if
markfresh_chat() is called meanwhile.
@iequidoo iequidoo marked this pull request as ready for review May 20, 2026 13:14
@iequidoo iequidoo requested review from WofWca and link2xt May 20, 2026 13:14
Copy link
Copy Markdown
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like this should work but I'm probably not the right person to ask.

IDK about introducing different behavior for tests though, it doesn't seem like something we often do at least. At least some comments about could be useful? But maybe it's obvious to someone who knows what they're reading.

@iequidoo
Copy link
Copy Markdown
Collaborator Author

iequidoo commented May 20, 2026

IDK about introducing different behavior for tests though, it doesn't seem like something we often do at least.

The smtp code (send_mdn_rfc724_mid() particularly) isn't tested at all in Rust currently. It's better to test it somehow than not test it at all, and running an SMTP server in Rust tests isn't what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

markfresh_chat() (Mark as Unread) doesn't work sometimes, because of late self-sent MDNs

2 participants