feat: Remove "Delete Messages from Server" (delete_server_after) config option, second try#8240
Draft
Hocuri wants to merge 2 commits into
Draft
feat: Remove "Delete Messages from Server" (delete_server_after) config option, second try#8240Hocuri wants to merge 2 commits into
Hocuri wants to merge 2 commits into
Conversation
…ig option, second try
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_delete_expired_imap_messages()is AI-generated and needs to be reworked. Everything else is written by myself and ready for review as soon as the tests pass.Supersedes #8217, fix #8195. If you want to see the difference, call
git diff hoc/remove-delete_server_after hoc/remove-delete_server_after-2(only works until someone rebases again, of course).The most interesting change is in
delete_expired_imap_messages()because there, messages are marked for deletion on single-device chatmail profiles.WRT tests:
test_immediate_autodelete()tests the auto-deletion;test_imap_autodelete_fully_downloaded_msg()tests that even for a message that is split into pre- and post-message, both messages are deleted.test_one_account_send_bcc_setting()andtest_markseen_message_and_mdn()relies on the fact that messages stay on the server when bcc_self is on.Open question: Do we want to treat Nauta.cu like a chatmail server, in order to keep the old behavior on Nauta of auto-deleting? If not, I'll tell @adbenitez how he can do it in AC. In order to do this, need to find out in
fn fetch_many_msgs()whether the server is Nauta, probably by querying thetransportsSQL tableTODO:
test_delete_expired_imap_messages()is AI-generated and needs to be reworkedtest_imap_autodelete_fully_downloaded_msgfails now (it passed in feat: Remove "Delete Messages from Server" (delete_server_after) config option #8217 IIRC)