Fix appending data while decimation is active - #12284
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11929
When decimation first runs, the plugin stores the original array in
_databut makes the publicdataset.datagetter return_decimated. Appending through the documenteddataset.data.push(...)path therefore updates only a temporary sampled array, while the next decimation pass still reads stale raw data.This keeps
dataset.databacked by the user-supplied raw array and makes dataset controllers consume_decimatedinternally. Scriptable contexts, segment contexts, and tooltip items now resolverawfrom the controller data so their indices continue to match the rendered sample. Existing decimation assertions use the rendered metadata length, and a regression test appends through the public data array and verifies the raw length, parsed tail, controller context, and tooltip item.Tests
{x: 9, y: 9}instead of{x: 10, y: 10}{x: 4, y: 4}instead of the rendered tail pointpnpm lint-js— 0 errorspnpm buildwith pnpm 8.13.0