[CRE-1587] - Increase retry/timeout resilience for GCS chunk retrieval - #155
Open
gallone2000 wants to merge 1 commit into
Open
Conversation
gallone2000
marked this pull request as ready for review
July 27, 2026 14:15
gallone2000
force-pushed
the
alessandro_cre_1587_increase-retrytimeout-resilience-for-gcs-chunk-retrieval
branch
2 times, most recently
from
July 28, 2026 13:54
ca8cf20 to
200cb4b
Compare
gallone2000
force-pushed
the
alessandro_cre_1587_increase-retrytimeout-resilience-for-gcs-chunk-retrieval
branch
from
July 29, 2026 13:14
200cb4b to
ee3068e
Compare
ReinierMaas
approved these changes
Jul 29, 2026
ReinierMaas
left a comment
ReinierMaas
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I have three small requests:
- Ensure that the commit name is descriptive of the change.
Comment on lines
+371
to
+373
| let client = | ||
| ObjectStoreClient::new_with_retry("memory:///", Vec::new(), tight_retry_config()) | ||
| .expect("memory:// URL should build with new_with_retry"); |
Contributor
There was a problem hiding this comment.
Different number of slashes between object_store_url and expect message. Probably the one from object_store_url should be used in the expect message.
Comment on lines
+401
to
+428
| /// A minimal service account JSON that carries `disable_oauth: true`, so | ||
| /// `GoogleCloudStorageBuilder::build()` succeeds without talking to any | ||
| /// external auth service. Mirrors the fake key used inside `object_store`'s | ||
| /// own test suite. | ||
| const FAKE_GCS_SERVICE_ACCOUNT_KEY: &str = r#"{ | ||
| "private_key": "private_key", | ||
| "private_key_id": "private_key_id", | ||
| "client_email": "client_email", | ||
| "disable_oauth": true | ||
| }"#; | ||
|
|
||
| #[test] | ||
| fn new_with_retry_builds_http_backend_without_network_io() { | ||
| // The HTTP arm of `new_with_retry` goes through `HttpBuilder`, which | ||
| // is a different code path from the `parse_url_opts` fallback covered | ||
| // by the memory:// and file:// tests. Building the client does not | ||
| // touch the network, so we can point it at an unreachable localhost | ||
| // port and still assert that construction succeeds. | ||
| let client = ObjectStoreClient::new_with_retry( | ||
| "http://127.0.0.1:1/some/prefix", | ||
| Vec::new(), | ||
| tight_retry_config(), | ||
| ) | ||
| .expect("http:// URL should build with new_with_retry"); | ||
| // Sanity-check the base path was captured (the URL segment after the | ||
| // authority). | ||
| assert!(format!("{client:?}").contains("some/prefix")); | ||
| } |
Contributor
There was a problem hiding this comment.
Move FAKE_GCS_SERVICE_ACCOUNT_KEY closer to the use-site, i.e. swap with new_with_retry_builds_http_backend_without_network_io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ObjectStoreClient::new_with_retryto allow callers to override the transport-level retry configuration per backend (GCS and HTTP), re-exportRetryConfig/BackoffConfig/Errorso downstream crates don't need a directobject_storedependency, and fix a regression where HTTP backend options were silently discarded instead of being forwarded toHttpBuilder.