Fix: allow ROLE_ADMIN to POST /api/course_rel_users for other users#8672
Open
addow wants to merge 1 commit into
Open
Fix: allow ROLE_ADMIN to POST /api/course_rel_users for other users#8672addow wants to merge 1 commit into
addow wants to merge 1 commit into
Conversation
…for other users The upstream security commit (2a9f060) added securityPostDenormalize to enforce self-enrollment, but omitted an admin bypass. Admins received 403 when subscribing any user other than themselves. Mirrors the ROLE_ADMIN bypass already present in CourseRelUserStateProcessor.
addow
force-pushed
the
fix/course-rel-user-admin-post
branch
from
aa36441 to
2cd1d3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
securityPostDenormalizeon the POST operation lacked an admin bypass: admins received 403 when subscribing any user other than themselvesROLE_ADMINfrom the post-denormalize checkROLE_ADMINbypass already present inCourseRelUserStateProcessorTest plan
user= another user → HTTP 201user= self → HTTP 201user= other user → HTTP 403