feat: Go 1.17 compatibility via build tags#2
Merged
Merged
Conversation
Split version-sensitive code into compat_modern.go (go1.18+) and compat_legacy.go (!go1.18) to support Go 1.17 compilation of the proton/file library without affecting modern builds. - fastwalk → filepath.WalkDir fallback - wasilibs/go-re2 → stdlib regexp fallback - mholt/archives → mholt/archiver v3 fallback - CI: add parallel Go 1.17 + Go 1.24 test jobs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Go 1.17 does not support the -toolchain flag in go mod edit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
templates/extract/credential/ does not exist in the templates submodule. The correct path is templates/proton_rules/credential/. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compat_modern.go(go1.18+) andcompat_legacy.go(!go1.18) via build tagsTest plan
🤖 Generated with Claude Code